Skip to content

fix(contract): close the last duplications and make the .shape trap impossible (#9762) #9765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 29, 2026
Merged

fix(contract): close the last duplications and make the .shape trap impossible (#9762) #9765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/loopover-contract/src/enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,27 @@ export type AutonomyLevel = (typeof AUTONOMY_LEVELS)[number];
* Do not "sync" this to the engine's list; the difference is the point.
*/
export const MAINTAIN_ACTION_CLASSES = ["review", "request_changes", "approve", "merge", "close", "label"] as const;

/**
* The engine's FULL action-class list (#9762).
*
* A superset of MAINTAIN_ACTION_CLASSES: the autonomy record is keyed by every class the agent can take,
* while the maintain dial exposes only the operator-settable subset. Restated here and pinned against
* @loopover/engine's own by a meta-test, the posture limits.ts established -- the settings response schema
* needs this list and cannot import the engine.
*/
export const AGENT_ACTION_CLASSES = [
"review",
"request_changes",
"approve",
"merge",
"close",
"label",
"review_state_label",
"update_branch",
"assign",
] as const;
export type AgentActionClass = (typeof AGENT_ACTION_CLASSES)[number];
export type MaintainActionClass = (typeof MAINTAIN_ACTION_CLASSES)[number];

/**
Expand Down
32 changes: 11 additions & 21 deletions packages/loopover-mcp/bin/loopover-mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ import {
getToolContract,
ListPendingActionsStdioInput,
} from "@loopover/contract/tools";
import type { ToolContract } from "@loopover/contract";
import { AUTONOMY_LEVELS as MAINTAIN_AUTONOMY_LEVELS, MAINTAIN_ACTION_CLASSES, PROPOSE_ACTION_CLASSES, type ToolContract } from "@loopover/contract";
import { buildBranchAnalysisPayload, collectLocalDiff, collectLocalBranchMetadata, probeLocalScorer, referenceScorePreviewExample, resolveScorePreviewCommand, resolveWorkspaceCwd, sanitizeLocalScorerStatus, setupGuidanceForLocalScorer, isTestFile } from "../lib/local-branch.js";
import { formatTable } from "../lib/format-table.js";
import { argsWantJson, describeCliError, reportCliFailure } from "../lib/cli-error.js";
Expand Down Expand Up @@ -359,28 +359,18 @@ const REPEATABLE_FLAGS = new Set(Object.entries(CLI_FLAG_SPEC).filter(([, kind])
const BOOLEAN_FLAGS = new Set(Object.entries(CLI_FLAG_SPEC).filter(([, kind]) => kind === "boolean").map(([flag]) => flag));
const COMPLETION_SHELLS = ["bash", "zsh", "fish", "powershell"];
const AGENT_PROFILE_IDS = ["miner-planner", "miner-auto-dev", "maintainer-triage", "repo-owner-intake"];
// #784 maintain set-level — the autonomy dial's action classes + levels.
// #784 maintain set-level — the autonomy dial's action classes + levels, from @loopover/contract.
//
// Both are hand-synced literals, not imports: this file resolves @loopover/engine through the PUBLISHED package
// (`^3.0.0`), whose export map exposes only `.` + a few `./scoring/*`/`./signals/*` subpaths — neither surfaces
// AUTONOMY_LEVELS, so importing the canonical list would mean widening the engine's public API (#6153). The
// drift this invites is real and has bitten once already, so test/unit/mcp-cli-maintain.test.ts pins LEVELS
// against the live enum and fails the moment the two disagree.
// #9762: these were hand-synced literals, justified by a comment saying the canonical lists could not be
// imported because this file resolves @loopover/engine through the PUBLISHED package, whose export map does
// not surface AUTONOMY_LEVELS (#6153). That reason went away when the contract did: this file already
// imports @loopover/contract, and the contract carries all three lists as its own pinned copies. The
// drift the old comment warned about (LEVELS carried "suggest"/"propose" for the whole life of #4620,
// after the server had dropped them) is now impossible rather than test-detected.
//
// LEVELS mirrors AUTONOMY_LEVELS (src/settings/autonomy.ts -> packages/loopover-engine/src/settings/autonomy.ts)
// exactly. #6153: it carried "suggest"/"propose" for the whole life of #4620, which dropped them server-side --
// PUT /settings validates against the live enum (src/api/routes.ts), so every value this list accepted but the
// server didn't turned an immediate, clear client-side error into a confusing 400 from the API.
//
// ACTION_CLASSES is deliberately NOT the engine's full AGENT_ACTION_CLASSES: it is the operator-settable subset
// the maintain surface exposes, and src/mcp/server.ts's MAINTAIN_AUTONOMY_ACTION_CLASSES mirrors these six on
// purpose. Do not "sync" it to the engine list.
const MAINTAIN_ACTION_CLASSES = ["review", "request_changes", "approve", "merge", "close", "label"];
const MAINTAIN_AUTONOMY_LEVELS = ["observe", "auto_with_approval", "auto"];
// #6744: the loopover_propose_action / POST .../agent/pending-actions action-class enum. A superset of
// MAINTAIN_ACTION_CLASSES (adds review_state_label) — kept separate so `maintain propose` accepts exactly what the
// route + MCP tool accept, while set-level keeps its own autonomy-configurable subset above.
const PROPOSE_ACTION_CLASSES = ["review", "request_changes", "approve", "merge", "close", "label", "review_state_label"];
// MAINTAIN_ACTION_CLASSES is deliberately NOT the engine's full AGENT_ACTION_CLASSES: it is the
// operator-settable subset the maintain surface exposes. PROPOSE_ACTION_CLASSES is that subset plus
// review_state_label, which the propose route accepts and the set-level dial does not.

// #783 plan DAG -- one implementation, in @loopover/engine (#9537). This file carried a
// hand-copied, untyped duplicate of buildPlanDag/validatePlanDag/nextReadySteps/the step state
Expand Down
Loading