Skip to content

fix(registry): canonicalize prediction-market category to prediction-markets#6464

Closed
glorydavid03023 wants to merge 1 commit into
JSONbored:mainfrom
glorydavid03023:fix/category-prediction-markets
Closed

fix(registry): canonicalize prediction-market category to prediction-markets#6464
glorydavid03023 wants to merge 1 commit into
JSONbored:mainfrom
glorydavid03023:fix/category-prediction-markets

Conversation

@glorydavid03023

Copy link
Copy Markdown
Contributor

Summary

Fixes #6332. The registry used two spellings for the same concept — prediction-market (8-ball.json SN125, sparket.json SN57) and prediction-markets (almanac.json SN41, degenbrain.json SN90) — so a category filter/facet for one spelling silently excluded the other two subnets.

This adopts the plural prediction-markets as canonical (per the issue's recommendation) and updates the two singular files.

  • registry/subnets/8-ball.json: prediction-marketprediction-markets
  • registry/subnets/sparket.json: prediction-marketprediction-markets

Plural matches the dominant convention elsewhere in the corpus (language-models, capital-markets, trading-strategies, developer-tools). Verified registry-wide that these were the only two files using the singular form; existing alphabetical ordering of categories[] is preserved in both files.

Per the issue this is a pure data fix — no categories enum is added (explicitly out of scope).

Expected outcome

A category filter for "prediction markets" now surfaces all 4 relevant subnets (SN41, SN57, SN90, SN125) instead of 2.

Validation

  • npm run validate:surface -- registry/subnets/8-ball.json → passed (5 surfaces)
  • npm run validate:surface -- registry/subnets/sparket.json → passed (5 surfaces)
  • npx prettier --check → clean
  • Diff is exactly 1 line per file, 2 files.

Closes #6332

@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

1 similar comment
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.86%. Comparing base (4d7989a) to head (83d8d9e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6464   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         176      176           
  Lines       22330    22330           
  Branches     8838     8838           
=======================================
  Hits        21853    21853           
  Misses         79       79           
  Partials      398      398           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix or unsolicited PR — scores a 0.05x multiplier. label Jul 17, 2026
@loopover-orb

loopover-orb Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - reject/close recommended

Review updated: 2026-07-17 10:52:12 UTC

2 files · 1 AI reviewer · 1 blocker · CI green · clean

🛑 Suggested Action - Reject/Close

Review summary
Pure data fix that renames the singular `prediction-market` category to the canonical plural `prediction-markets` in exactly two files (8-ball.json, sparket.json), matching the two files that already used the plural form (almanac.json, degenbrain.json). Diff is minimal, alphabetical ordering of categories[] is preserved in both files, and no other fields are touched, matching the issue's explicit scope (no new enum, pure data correction).

Nits — 2 non-blocking
  • Only registry/subnets files were checked for this string per the PR description; worth confirming no other consumer (e.g. a docs page or filter config) hardcodes the singular `prediction-market` spelling.
  • If any generated facet/category index elsewhere in the repo caches category strings, regenerate it in a follow-up to reflect the renamed value.

Why this is blocked

  • Registry surface review
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. Registry surface review

Decision drivers

  • ❌ Code review — 1 blocker (1 reviewer)
  • ❌ Gate result — Blocking (Repo-configured hard blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6332
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 290 registered-repo PR(s), 176 merged, 15 issue(s).
Contributor context ✅ Confirmed Gittensor contributor glorydavid03023; Gittensor profile; 290 PR(s), 15 issue(s).
Linked issue satisfaction

Addressed
The PR updates both 8-ball.json and sparket.json to replace 'prediction-market' with the canonical plural 'prediction-markets', exactly matching the issue's stated deliverable and expected outcome, and does not introduce a categories enum, respecting the out-of-scope note.

Review context
  • Author: glorydavid03023
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, TypeScript, Rust, C++, Kotlin, MDX, Ruby
  • Official Gittensor activity: 290 PR(s), 15 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (Registry surface review). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix or unsolicited PR — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Category taxonomy drift: "prediction-market" vs "prediction-markets" both in use for the same concept

1 participant