Skip to content

Remove cohp module and update related codes, tests, and documentation - #451

Merged
naik-aakash merged 7 commits into
JaGeo:mainfrom
naik-aakash:delete_cohp
Aug 5, 2026
Merged

Remove cohp module and update related codes, tests, and documentation#451
naik-aakash merged 7 commits into
JaGeo:mainfrom
naik-aakash:delete_cohp

Conversation

@naik-aakash

Copy link
Copy Markdown
Collaborator

Changes

  • Deleted decrecated cohp module in favour of coxx
  • Updated tests, docs, tutorial of match new api

@naik-aakash naik-aakash added documentation Improvements or additions to documentation housekeeping labels Aug 5, 2026
@naik-aakash
naik-aakash enabled auto-merge August 5, 2026 13:16
@naik-aakash

Copy link
Copy Markdown
Collaborator Author

Hi @JaGeo , this PR is ready to be merged

@JaGeo

JaGeo commented Aug 5, 2026

Copy link
Copy Markdown
Owner

@tomdemeyere could you review? Thank you!

@naik-aakash
naik-aakash requested a review from tomdemeyere August 5, 2026 13:34
@tomdemeyere

Copy link
Copy Markdown
Collaborator

Amazing cleaning, from what I can see the biggest changes are a simplification of some __init__.py which had two ways of doing the same thing, moving one logic to from_files classmethods. Also deletion of the get_lobster_calc_quality_summary duplicate is nice.

In src/lobsterpy/cli.py there are still two comments mentioning "lobsterpy.cohp", the rest looks good to me

@naik-aakash

Copy link
Copy Markdown
Collaborator Author

Amazing cleaning, from what I can see the biggest changes are a simplification of some __init__.py which had two ways of doing the same thing, moving one logic to from_files classmethods. Also deletion of the get_lobster_calc_quality_summary duplicate is nice.

In src/lobsterpy/cli.py there are still two comments mentioning "lobsterpy.cohp", the rest looks good to me

Thanks 😄 , I updated the comment in cli module now.

@naik-aakash
naik-aakash merged commit 9b630a5 into JaGeo:main Aug 5, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants