You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Amazing cleaning, from what I can see the biggest changes are a simplification of some __init__.py which had two ways of doing the same thing, moving one logic to from_files classmethods. Also deletion of the get_lobster_calc_quality_summary duplicate is nice.
In src/lobsterpy/cli.py there are still two comments mentioning "lobsterpy.cohp", the rest looks good to me
Amazing cleaning, from what I can see the biggest changes are a simplification of some __init__.py which had two ways of doing the same thing, moving one logic to from_files classmethods. Also deletion of the get_lobster_calc_quality_summary duplicate is nice.
In src/lobsterpy/cli.py there are still two comments mentioning "lobsterpy.cohp", the rest looks good to me
Thanks 😄 , I updated the comment in cli module now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes