BACKLOG-23366: Merge npm-modules-engine and js-server-core - #1
Merged
Conversation
baptistegrimaud
force-pushed
the
BACKLOG-23366
branch
6 times, most recently
from
November 18, 2024 18:32
1ed97e3 to
37954b1
Compare
baptistegrimaud
force-pushed
the
BACKLOG-23366
branch
3 times, most recently
from
November 19, 2024 10:38
de6db0f to
ee12226
Compare
baptistegrimaud
force-pushed
the
BACKLOG-23366
branch
from
November 19, 2024 10:53
ee12226 to
57eb9c1
Compare
3 tasks
jkevan
approved these changes
Nov 19, 2024
baptistegrimaud
enabled auto-merge (squash)
November 19, 2024 16:11
This was referenced Nov 27, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/BACKLOG-23366
Description
Merge https://github.com/Jahia/npm-modules-engine and https://github.com/Jahia/js-server-core repositories.
Important changes
"resolutions"section of thepackage.json, we use thefileprotocol so we can have a dependency towards the Javascript Modules Library package. The advantage of this is that the transitive dependencies are computed the same way as if the package was declared as a regular dependency and the checksum of that package in theyarn.lockdoes not change (which is the case when using a path to the tgz file):yarn pack. This allows the Maven version to be injected in thepackage.jsonso both the Java and Javascript modules share the same versioningnpm publishunder the hoodInitial creation of the repository
To initialize the repository, the following script has been used:
The goal was to simply group the 2 repositories in the same repository https://github.com/Jahia/javascript-modules, by putting the files in
javascript-modules-engine/andjavascript-modules-library/for respectively https://github.com/Jahia/npm-modules-engine and https://github.com/Jahia/js-server-core.The purpose of this PR is then to make the multi-module repository working for both the Java engine and the Javascript library.