Update kotest to 6.2.4, and drop the module it absorbed - #56
Merged
Conversation
io.kotest:kotest-framework-datatest was never published past 5.9.1. Its contents moved into kotest-framework-engine, which already arrives transitively through kotest-runner-junit5, so there is nothing to migrate to and nothing to replace it with. Renovate moved every kotest artifact together through the shared version reference and asked for a coordinate that does not exist, so the build failed at dependency resolution before compiling anything. That is why it failed in two minutes rather than the four a real test run takes. Nothing here ever used it. There is no io.kotest.datatest import and no withData in either test source set, so it has been an unused dependency for as long as it has been declared, and only became visible when it stopped existing. Nothing else in the major needed changing. AbstractProjectConfig and the spec execution order it sets are unchanged, no call site moved, and the run produces no deprecation warnings. 319 tests green, detekt clean. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io.kotest:kotest-framework-datatestwas never published past5.9.1. Its contents moved intokotest-framework-engine, which already arrives transitively throughkotest-runner-junit5, sothere is nothing to migrate to and nothing to replace it with.
Renovate moved every kotest artifact together through the shared version reference and asked for a
coordinate that does not exist, so #52 failed at dependency resolution before compiling anything.
That is why it failed in two minutes rather than the four a real test run takes:
It was never used
There is no
io.kotest.datatestimport and nowithDataanywhere in either test source set. It hasbeen an unused dependency for as long as it has been declared, and it only became visible when it
stopped existing.
Nothing else in the major needed changing
KotestConfigextendsAbstractProjectConfigand sets a spec execution order, which is the kind ofAPI that usually moves in a framework major. It did not. No call site changed, and the run produces
no kotest deprecation warnings.
Verified against the authoritative Maven metadata rather than the search index, which is stale and
still reports
6.0.0.M4as newest:kotest-runner-junit5kotest-assertions-corekotest-propertykotest-framework-enginekotest-framework-datatestAnd that
io/kotest/datatest/really is insidekotest-framework-engine-jvm-6.2.4.jar.Tests
319 green, detekt clean.
Supersedes #52, which cannot pass as generated.