Skip to content

TEC-11 CI pipeline no longer runs on draft pull request. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesAlp merged 1 commit into from
Apr 22, 2026
Merged

TEC-11 CI pipeline no longer runs on draft pull request. #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ on:
- opened
- synchronize
- reopened
- ready_for_review

jobs:
client-audit:
name: Client Audit
runs-on: ubuntu-latest
if: github.event.pull_request.base.ref == 'master'
if: github.event.pull_request.draft == false && github.event.pull_request.base.ref == 'master'

defaults:
run:
Expand Down Expand Up @@ -44,7 +45,7 @@ jobs:
runs-on: ubuntu-latest
needs:
- client-audit
if: always() && (needs.client-audit.result == 'success' || needs.client-audit.result == 'skipped')
if: github.event.pull_request.draft == false && always() && (needs.client-audit.result == 'success' || needs.client-audit.result == 'skipped')

defaults:
run:
Expand Down
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,13 @@ Pull request validation is currently defined in:

The current workflow:

- runs on pull request `opened`, `synchronize`, and `reopened`
- runs on pull request `opened`, `synchronize`, `reopened`, and `ready_for_review`
- uses `ubuntu-latest`
- uses `pnpm` version `10`
- uses `Node.js` version `22`
- runs the client unit test suite on pull requests regardless of target branch
- skips draft pull requests so CI only runs once the pull request is ready for review
- future pull request pipelines in this repository should also skip draft pull requests and wait until `ready_for_review`
- runs the client unit test suite on non-draft pull requests regardless of target branch
- runs a `pnpm audit --audit-level high` job in `client/` only for pull requests targeting `master`
- blocks the `master` pull request workflow when the client audit finds any vulnerability at `high` severity or above
- installs dependencies in `client/` with `pnpm install --frozen-lockfile`
Expand Down
10 changes: 7 additions & 3 deletions agents.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,13 @@ Current frontend decision:
- pull request CI is configured at the repository root with GitHub Actions so it can expand beyond the `client` app over time
- the current pull request workflow runs the `client` unit test suite with `pnpm`
- the current pull request workflow file is `.github/workflows/pull-request.yml`
- the current pull request workflow runs on `opened`, `synchronize`, and `reopened` pull request events
- the current pull request workflow runs on `opened`, `synchronize`, `reopened`, and `ready_for_review` pull request events
- the current pull request workflow uses `ubuntu-latest`, `pnpm` version `10`, and `Node.js` version `22`
- the current pull request workflow installs dependencies in the `client` directory with `pnpm install --frozen-lockfile`
- the current pull request workflow runs `client-unit-tests` for pull requests regardless of target branch
- the current pull request workflow runs a `client-audit` job in the `client` directory with `pnpm audit --audit-level high` only when the pull request targets `master`
- the current pull request workflow skips draft pull requests so CI only runs after the pull request is ready for review
- future pull request pipelines and workflows in this repository should also skip draft pull requests and only start when the pull request is ready for review
- the current pull request workflow runs `client-unit-tests` for non-draft pull requests regardless of target branch
- the current pull request workflow runs a `client-audit` job in the `client` directory with `pnpm audit --audit-level high` only when a non-draft pull request targets `master`
- the current pull request workflow requires the `client-audit` job to pass before running `client-unit-tests` when the audit job runs, but still allows tests to run when the audit job is skipped on non-`master` targets
- the current pull request workflow runs tests from the `client` directory with `pnpm exec jest --runInBand`
- the repository now includes a root `.vscode/settings.json` that enables format-on-save and ESLint fix-on-save for the `client` app workspace
Expand Down Expand Up @@ -256,6 +258,8 @@ These details are not defined yet:
- Recorded that pull request CI should continue running `client-unit-tests` for pull requests to any target branch.
- Recorded that pull request CI now starts with a `client-audit` job only for pull requests targeting `master`, where it runs `pnpm audit --audit-level high` in `client`.
- Recorded that `client-unit-tests` now wait for the audit job only when that audit runs, while still running normally when the audit is skipped on non-`master` pull requests.
- Recorded that pull request CI should skip draft pull requests and instead start when the pull request becomes ready for review.
- Recorded the standing repository rule that future pull request pipelines should also skip draft pull requests and wait for `ready_for_review`.

### 2026-04-18

Expand Down
Loading