docs: record ECC backport in 2026-05-12 sync round log#73
Merged
Conversation
While porting 0dcde13 (block-no-verify shell-words rewrite) in #68, CodeRabbit's round-3 review surfaced two real bypass holes that EGC inherited verbatim from ECC: - core.hooksPath case-sensitivity bypass (critical) - -tn false positive (major) Both fixes shipped to EGC in #68 (commit fbf7908). Also backported upstream to ECC as affaan-m/everything-claude-code#1843 per the dual-PR pattern in CONTRIBUTING.md — first contribution flowing the other direction from this sync round. Audit log updated so the provenance is on the record.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new "Backports to upstream ECC" subsection documents two security bypass vulnerabilities discovered during upstream ECC round-3 review: a ChangesSync-round audit log update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Backports to upstream ECC" section to
upstream/sync-rounds/2026-05-12.mdrecording the two block-no-verify bypass holes that flowed back upstream as affaan-m/everything-claude-code#1843.Why
Per the dual-PR pattern in
CONTRIBUTING.md: when a contribution to EGC is harness-agnostic and would also benefit ECC users, cross-link the two PRs so reviewers on either side can see the upstream/downstream pair. This is the first sync round where work flowed from EGC back to ECC, so the audit log should record it.Test plan
What ships in the upstream PR (cross-link)
Both originally discovered in EGC PR #68 (commit fbf7908) by CodeRabbit's round-3 review.
Summary by cubic
Adds a “Backports to upstream ECC” section to
upstream/sync-rounds/2026-05-12.mddocumenting two block-no-verify bypass fixes and cross-linking the upstream/downstream pair per the dual-PR pattern.core.hooksPathcase-insensitivity bypass:git -c core.hookspath=…was not caught.-tnfalse positive: missing't'in short options caused validgit commit -tn templateto be blocked.Written for commit e67c5e1. Summary will update on new commits.
Summary by CodeRabbit