Skip to content

fix: profile menu rendered under properties panel content#178

Merged
allison-truhlar merged 1 commit intomainfrom
fix-profile-menu-z-index
Sep 26, 2025
Merged

fix: profile menu rendered under properties panel content#178
allison-truhlar merged 1 commit intomainfrom
fix-profile-menu-z-index

Conversation

@allison-truhlar
Copy link
Collaborator

Clickup id: 86ac29c1x

@krokicki @neomorphic
This PR increases the z-index of the content of the profile menu. The content is now correctly rendered on top of the properties panel content, and content on other pages.

Copy link
Member

@neomorphic neomorphic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The z-index change looks good to me. Not sure why the "@jupyterlab/rendermime" needed to be updated though.

@allison-truhlar
Copy link
Collaborator Author

Not sure why the "@jupyterlab/rendermime" needed to be updated though.

Yeah, I'm still working on that. I got a release error and then the attempt to fix it resulted in a build error but no release error.

@allison-truhlar
Copy link
Collaborator Author

@neomorphic Looks like the build/release errors were a fluke. I removed the changes to the package.json and package-lock.json

@allison-truhlar allison-truhlar merged commit 6a2d381 into main Sep 26, 2025
9 of 10 checks passed
@allison-truhlar allison-truhlar deleted the fix-profile-menu-z-index branch September 26, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments