feat: data link playwright tests #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tried adding a label to the button itself, but it seems something about the way the tanstack table is built the label is not found by Playwright
neomorphic
approved these changes
Oct 21, 2025
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
Looks good to me. All the tests passed when I tried it out. I added a suggest to make the reports easier to read.
| // Step 5: Find the link in the table by looking for the zarr directory name | ||
| const linkRow = page.getByText(zarrDirName, { exact: true }); | ||
| await expect(linkRow).toBeVisible(); | ||
|
|
Member
There was a problem hiding this comment.
wrapping each section with a test.step() will make the final report easier to read. Rather than having to look through a wall of expect results, you can jump to the section that has failed.
eg: await test.step('Delete link via Links page', async () => {
// test code here
});
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion! I made this change in commit 1d95bd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86acm69nc
@krokicki @neomorphic
This PR adds a Playwright test to test the following sequence of actions:
/linkspage and delete the data link using the actions menu