Skip to content

Conversation

@neomorphic
Copy link
Member

Clickup ID: 86acpdgbu

  • fix(security): Generates random session secret on server startup.
  • fix(security): invalidate sessions when server secret key changes
    @krokicki

Rather than use a poor default secret, the server now generates one at
random if the session_secret_key value has not been provided by the
server admin.
- Adds a new database column via Alembic migration
- Stores the hashed session secret key when creating sessions (fileglancer/database.py:554)
- Validates the session secret key hash on each request (fileglancer/auth.py:88-93)
- Passes the session secret key to session creation in both OKTA and simple auth flows (fileglancer/app.py:307, 1091)
@neomorphic neomorphic requested a review from krokicki October 21, 2025 14:58
@krokicki krokicki merged commit ac5ba34 into main Oct 21, 2025
7 checks passed
@krokicki krokicki deleted the generate_random_session_secret_key branch October 21, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants