fix: clicking on filtered data link table does not reset state #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neomorphic
reviewed
Nov 12, 2025
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
The fix works, but I question if it is the correct UI? Should clicking outside of the filter pop up clear the filter or should it simply close the filter pop up and leave the filter in place? I think leaving the filter in place is what I would expect from the UI. Maybe add a small red dot to the search icon to indicate that a filter has been applied. Then, if I wish to remove the filter I can click on the icon and clear the text from the pop over.
- removes individual column pop-up filter inputs
Collaborator
Author
|
@neomorphic I changed the search UI - now it's one input that searches all the columns. The input does not clear unless the user explicitly clicks the clear button. |
Member
|
I think this is much more intuitive than the pop overs. I approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup ids: 86acthka5, 86acwmgfg
This PR changes the table filtering UI to a single search input that searches across all the table columns. It fixes the problem of the filter state clearing when the user clicked outside the search input - the filter state only clears (and subsequently resets the table) if you explicitly click the clear button. The PR also adds an end-to-end test to verify these behaviors.