fix: recently viewed folders bug #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neomorphic
approved these changes
Nov 24, 2025
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
This is now working as expected and I can see recently viewed paths again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krokicki
Recently viewed folders appeared to be coming back correctly from the /preference endpoint, but were disappearing from the dashboard. In a previous PR, I introduced a bug by swapping the
filePathandfspNameparameters in the function that updates the recently viewed folders. This resulted in the frontend logic being unable to form and display the folder links because thefspNamesprovided from the backend were incorrect (they were actuallyfilePaths). So each time you navigated to a new folder that was added to recently viewed folders, it effectively deleted one recently viewed folder from the display in the dashboard, until all the data was bad and the display was empty.This PR also adds a fix to address a linter warning that
filePathorfspNamecould beundefinedwhen passed to updateRecentlyViewedFolders.To test this fix, you will need to delete any existing recentlyViewedFolders in your database (specifically if you used the database at all while the bug existed, over the past week or so):
sqlite3 fileglancer.db "DELETE FROM user_preferences WHERE key='recentlyViewedFolders';"