fix: properties drawer updates when clicking one level up in the bread crumbs #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not update from a useEffect - this was causing race conditions with the first useEffect, which updates the propertiesTarget on navigation - also add useEffect to update the name of a propertiesTarget because using the rename dialog will always result in renaming a propertiesTarget that is the child of the currentFileOrFolder, and therefore can't rely on the updated fileQuery.data
neomorphic
approved these changes
Nov 24, 2025
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
I tried it out and it looks like it is working for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86adeymat
@krokicki
This PR fixes race conditions and improves state management in the file properties drawer. The changes refactor how
propertiesTargetis derived and updated, ensuring the properties drawer displays the correct file information when navigating up levels in the bread crumbs, changing file permissions, and renaming files. The main improvements are derivingpropertiesTargetdirectly fromfileQuery.data, and creating a separate internalpropertiesTargetPaththat can be updated on navigation via auseEffectand then used to derive thepropertiesTargetobject.Changes
frontend/src/contexts/FileBrowserContext.tsx: Refactored
propertiesTargetstate management to derive it fromfileQuery.datawith separate useEffect handlers for navigation and rename operations.frontend/src/queries/fileQueries.ts: Simplified by removing unnecessary optimistic update logic from the file permission mutation and unused/invalid signal parameter from the rename file mutation.
To test