fix: copy auto-created data links #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab8325e.
- handleToolClick accounts for the case where the data URL does not exist yet
allison-truhlar
requested review from
neomorphic
and removed request for
neomorphic
neomorphic
approved these changes
Dec 8, 2025
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
Looks good to me. The data link creation confirmation dialog popped up instead of the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86adr8f4a
@krokicki
This PR reverts a commit that replaced the previous logic for handling copying the data links from the copy link icon (
onToolClick) with thehandleCopyfunction. The latter function does not handle the case where the data link does not yet exist.This PR also adds a Playwright test to check that, in the case where auto-create data links is turned on and a data link does not yet exist for a directory, clicking on the 'copy URL' button does shows success messages for creating a data link and that the link was copied.