feat: support OME-Zarr labels metadata #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokicki
changed the title
Collaborator
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86acd9txj
This PR adds support for OME-Zarr labels. In particular, we now check for the presence of labels in the
labelsgroup in both Zarr v2 and v3. If labels are found, they are a) shown in the metadata table, and b) added to Neuroglancer state (when state generation is not disabled in preferences).Due to current limitations in Neuroglancer's NGFF support (outlined in issues 869 and 870), we need to go back to generating the full Neuroglancer state for the OME-Zarr. Therefore, as part of this PR I revisited the "legacy" processing, updated it to match the new native multichannel loading, and renamed it (the preference is still named "legacy" for backwards compatibility). For now I'm only using this method when there are labels present, and using the default NGFF support otherwise.
I also did some code clean up around typing and other minor issues in the related files.
@JaneliaSciComp/fileglancer @StephanPreibisch