fix: remove unneeded e.currentTarget.blur() calls #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removing these did not change the visual appearance of the buttons/tooltips, and is better for accessibiity, keeping the expected tab behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86adx9mee
This PR removes the
e.currentTarget.blur()calls from the end of eachonClickmethod for the Toolbar buttons. This has the benefit of eliminating the error printed to the console related to the target being null for the view dot file button. This removal did not change the visual appearance of the buttons/tooltips, and is better for accessibility by not breaking the expected tab behavior. Further, one button (add new folder), did not havee.currentTarget.blur(), so this makes the button logic more consistent.@krokicki