Add configuration props for CQL PoolingOptions #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhwang
force-pushed
the
add-cql-properties
branch
from
156b042 to
c425332
Compare
robertdale
requested changes
Nov 30, 2017
| configuration.get(REMOTE_CORE_CONNECTIONS_PER_HOST)) | ||
| .setConnectionsPerHost( | ||
| HostDistance.REMOTE, | ||
| configuration.get(LOCAL_MAX_CONNECTIONS_PER_HOST), |
Member
There was a problem hiding this comment.
I think REMOTE_CORE_CONNECTIONS_PER_HOST and LOCAL_MAX_CONNECTIONS_PER_HOST are switched.
Contributor
Author
There was a problem hiding this comment.
You're right. fixed. Thanks
yhwang
force-pushed
the
add-cql-properties
branch
2 times, most recently
from
09218e6 to
f382c3f
Compare
robertdale
approved these changes
Dec 2, 2017
analytically
reviewed
Dec 3, 2017
|
|
||
| ConfigOption<Integer> LOCAL_CORE_CONNECTIONS_PER_HOST = new ConfigOption<>( | ||
| CQL_NS, | ||
| "local-core-connection-per-host", |
Contributor
There was a problem hiding this comment.
local-core-connections-per-host? same for the others
Contributor
Author
There was a problem hiding this comment.
@analytically I fixed and updated my branch.
Make CQL PoolingOptions be configurable by adding the following new properties under `storage.cql` : - local-core-connection-per-host: The number of connections initially created and kept open to each host for local datacenter - local-max-connection-per-host: The maximum number of connections that can be created per host for local datacenter - local-max-request-per-connection: The maximum number of requests per connection for local datacenter - remote-core-connection-per-host: The number of connections initially created and kept open to each host for remote datacenter - remote-max-connection-per-host: The maximum number of connections that can be created per host for remote datacenter - remote-max-request-per-connection: The maximum number of requests per connection for remote datacenter Ref: related issue JanusGraph#775 Signed-off-by: Yihong Wang <yh.wang@ibm.com>
yhwang
force-pushed
the
add-cql-properties
branch
from
f382c3f to
b9a9f6d
Compare
analytically
approved these changes
Dec 4, 2017
bwatson-rti-org
pushed a commit
to bwatson-rti-org/janusgraph
that referenced
this pull request
Mar 9, 2019
Add configuration props for CQL PoolingOptions
| CQL_NS, | ||
| "local-core-connections-per-host", | ||
| "The number of connections initially created and kept open to each host for local datacenter", | ||
| ConfigOption.Type.FIXED, |
There was a problem hiding this comment.
Any specific reason why this configuration is of type FIXED?
There was a problem hiding this comment.
I'm asking because it does not seem clear to me why this could not be changed later on. Just asking to understand if there is some reason that I'm missing.
micpod
pushed a commit
to micpod/janusgraph
that referenced
this pull request
Nov 5, 2019
Add configuration props for CQL PoolingOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CQL PoolingOptions be configurable by adding the following new
properties under
storage.cql:The number of connections initially created and kept open to each host
for local datacenter
The maximum number of connections that can be created per host for
local datacenter
The maximum number of requests per connection for local datacenter
The number of connections initially created and kept open to each host
for remote datacenter
The maximum number of connections that can be created per host for
remote datacenter
The maximum number of requests per connection for remote datacenter
Ref: related issue #775
Signed-off-by: Yihong Wang yh.wang@ibm.com
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master)?For code changes:
Note:
Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.