Skip to content

Use final for state as much as possible in core#785

Merged
amcp merged 1 commit intoJanusGraph:masterfrom
amcp:final
Dec 3, 2017
Merged

Use final for state as much as possible in core#785
amcp merged 1 commit intoJanusGraph:masterfrom
amcp:final

Conversation

@amcp
Copy link

@amcp amcp commented Dec 2, 2017

Addresses #783 in part

Signed-off-by: Alexander Patrikalakis amcp@amazon.co.jp


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?
  • If this PR is a documentation-only change, have you added a [skip ci]
    tag to the first line of your commit message to avoid spending CPU cycles in
    Travis CI when no code, tests, or build configuration are modified?

Note:

Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.

@amcp amcp requested a review from sjudeng December 2, 2017 20:31
@janusgraph-bot janusgraph-bot added the cla: yes This PR is compliant with the CLA label Dec 2, 2017
@amcp amcp requested a review from analytically December 3, 2017 11:02
Addresses JanusGraph#783 in part

Signed-off-by: Alexander Patrikalakis <amcp@amazon.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This PR is compliant with the CLA kind/cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments