Xrc 1218 port uvatlas to linux - #1
Conversation
DillonSkeehan
left a comment
DillonSkeehan
left a comment
There was a problem hiding this comment.
Looks mostly okay, what files should we explicitly be looking at?
| <OutDir>Bin\Desktop_2017_Win10\$(Platform)\$(Configuration)\</OutDir> | ||
| <IntDir>Bin\Desktop_2017_Win10\$(Platform)\$(Configuration)\</IntDir> | ||
| <TargetName>UVAtlas</TargetName> | ||
| <TargetName>UVAtlasd</TargetName> |
There was a problem hiding this comment.
I don't think we normally commit vcxproj?
There was a problem hiding this comment.
MS originally had all these vs sln files in the repo. This was just to update the naming of the output library. I originally used this before I setup the cmake stuff.
| namespace DirectX | ||
| { | ||
|
|
||
| XM_CONST float XM_PI = 3.141592654f; |
There was a problem hiding this comment.
may want to define these to whats included in <math.h>
There was a problem hiding this comment.
My preference here is to stick with the same values as the MS SDK. This was a copy paste.
|
@DillonSkeehan I would say CMake, and all the .h & .cpp except JntLinuxTypes.h & dxgiformat.h (these are just copy pastes from the SDK). |
|
Updated with @DillonSkeehan comments. If there are no red flags I think we can call this good. |
|
merging this |
3 participants
@svensht2 @DillonSkeehan wanted some eyes on to make sure there are no major red flags but everything seems to work.