chore: remove dead code, unused deps and unreferenced assets - #8
Merged
Conversation
- Strip AppComponent of unused standalone-component imports and a duplicate dark/light theme implementation that never ran (its target elements only exist inside ButtonToggleDarkLightComponent, which already handles the toggle). - Drop FormsModule, angular-font-awesome and @fortawesome/angular-fontawesome imports: no template in the app uses ngModel/formControl or <fa-icon>. - Remove now-unused dependencies (express, angular-font-awesome, @fortawesome/angular-fontawesome, @angular/forms, @angular/platform-browser-dynamic) and sync package-lock.json. - Delete serve-node.js, the orphaned local Express server superseded by the GitHub Pages Actions deploy. - Delete 14 assets (images/fonts/license files) with zero references in the codebase. - Clean deprecated `purge` key and dead commented-out config from tailwind.config.js. Verified with a clean `ng build`: no more NG8113 unused-import warnings, no Tailwind config warning, initial bundle down from 507.41 kB to 414.96 kB (back under the 500 kB budget).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
purgekey and dead commented-out config from tailwind.config.js.Verified with a clean
ng build: no more NG8113 unused-import warnings, no Tailwind config warning, initial bundle down from 507.41 kB to 414.96 kB (back under the 500 kB budget).