Skip to content

feat: search the MDN - #12

Merged
AsyncBanana merged 35 commits into
mainfrom
feature/docs-search
Aug 27, 2023
Merged

feat: search the MDN#12
AsyncBanana merged 35 commits into
mainfrom
feature/docs-search

Conversation

@MorganVonBrylan

Copy link
Copy Markdown
Contributor

Adds a /mdn command to search through the MDN

Closes #3

Even though it's kinda useless
Making it immediately obvious there isn't an 'else' and reducing the indentation is good
I knew I had left my jank somewhere...
To ensure they don't exceed the value length limit or 100 chars
Discord won't parse links surrounded with backticks
So when the <a> is inside the <code> instead of the other way around, we reverse it
It's hard to give it an explicit name and the regex is unreadable
@MorganVonBrylan MorganVonBrylan linked an issue Aug 24, 2023 that may be closed by this pull request

@AsyncBanana AsyncBanana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caching behavior should likely be changed, but there aren't too many other problems.

Comment thread src/index.ts Outdated
Comment thread src/scraper.ts Outdated
Comment thread src/scraper.ts Outdated
Comment thread src/scraper.ts Outdated
Comment thread package.json
Comment thread src/scraper.ts Outdated

@AsyncBanana AsyncBanana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AsyncBanana
AsyncBanana merged commit 96324a5 into main Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs shortcut

2 participants