Skip to content

Flatten project language icons - #47

Merged
Jay1 merged 1 commit into
mainfrom
jcode/flatten-project-language-icons
Jun 1, 2026
Merged

Flatten project language icons#47
Jay1 merged 1 commit into
mainfrom
jcode/flatten-project-language-icons

Conversation

@Jay1

@Jay1 Jay1 commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the circular badge background, border, and shadow from project language icons.
  • Increase the rendered technology icon size inside the existing sidebar icon slot.
  • Extend the Playwright browser assertion to lock transparent backgrounds and the larger SVG treatment.

Test Plan

  • bunx oxfmt@0.52.0 --check apps/web/src/components/ProjectSidebarIcon.tsx apps/web/src/components/ProjectSidebarIcon.browser.tsx
  • bun run --cwd apps/web test:browser src/components/ProjectSidebarIcon.browser.tsx
  • bun run --cwd apps/web typecheck

Summary by CodeRabbit

  • Bug Fixes
    • Refined project sidebar icon styling with simplified presentation and improved sizing proportions.
    • Removed background colors from project icons for a cleaner visual appearance.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c8008353-6aaa-4e34-8554-0acdcc251d5c

📥 Commits

Reviewing files that changed from the base of the PR and between 4471d71 and c06ae2e.

📒 Files selected for processing (2)
  • apps/web/src/components/ProjectSidebarIcon.browser.tsx
  • apps/web/src/components/ProjectSidebarIcon.tsx

📝 Walkthrough

Walkthrough

The PR simplifies project icon artwork by removing per-icon background styling from the data structure and component rendering. The ProjectIconArtwork type and artwork records no longer carry background values, and the icon renderer applies only foreground color with updated sizing. Test assertions now validate the transparent background and adjusted SVG class.

Changes

Icon artwork simplification

Layer / File(s) Summary
Data structure and icon rendering updates
apps/web/src/components/ProjectSidebarIcon.tsx
ProjectIconArtwork type removes the background field; PROJECT_ICON_ARTWORK records are cleaned up to drop per-icon background RGBA values. Icon rendering for iconMetadata removes background styling, simplifies the container className, and increases inner icon sizing from size-[82%] to size-[94%].
Test assertions for icon rendering
apps/web/src/components/ProjectSidebarIcon.browser.tsx
First test expanded to assert the rendered <svg> exists, includes the size-[94%] class, has a transparent computed backgroundColor, and retains the brand color check.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Jay1/jcode#46: Directly aligned refactor of branded language icon SVG rendering and matching ProjectSidebarIcon test expectations for background removal.
  • Jay1/jcode#39: Initial introduction of iconMetadata and icon rendering work in ProjectSidebarIcon; this PR refines the styling approach.

Suggested labels

vouch:trusted, size:S

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Flatten project language icons' directly and concisely captures the main change—simplifying project icons by removing background styling and border/shadow elements.
Description check ✅ Passed The description provides a clear summary of changes, explains the motivation, and includes a comprehensive test plan with all required checks marked as completed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jun 1, 2026
@Jay1
Jay1 merged commit 63c6082 into main Jun 1, 2026
8 checks passed
@Jay1
Jay1 deleted the jcode/flatten-project-language-icons branch June 1, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant