Skip to content

adding color argument#781

Merged
javizqh merged 5 commits into
JdeRobot:humble-develfrom
anishk85:quadrotor-colorv2
Jul 24, 2026
Merged

adding color argument#781
javizqh merged 5 commits into
JdeRobot:humble-develfrom
anishk85:quadrotor-colorv2

Conversation

@anishk85

Copy link
Copy Markdown
Collaborator

giving different colors to both cat and drone mouse using poses

not touching quadrotor because it is used by other excersices as well.

@anishk85 anishk85 mentioned this pull request Jul 23, 2026
Comment thread database/worlds.sql
28 Dingo Low Noise /home/ws/src/CustomRobots/dingo/launch/dingo.launch.py do150 noise:=low namespace:=do150 dingo/model/dingo/dingo.urdf.xacro
29 Dingo Medium Noise /home/ws/src/CustomRobots/dingo/launch/dingo.launch.py do150 noise:=med namespace:=do150 dingo/model/dingo/dingo.urdf.xacro
30 Dingo High Noise /home/ws/src/CustomRobots/dingo/launch/dingo.launch.py do150 noise:=high namespace:=do150 dingo/model/dingo/dingo.urdf.xacro
31 Quadrotor Cat /home/ws/src/CustomRobots/quadrotor/launch/quadrotor.launch.py drone sensor:=camera namespace:=drone color:=Orange quadrotor/models/quadrotor/quadrotor.urdf.xacro

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this one. It is a complete duplicate of Quadrotor

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but i want to give it a color majenta
if i do so all other excersices using that would be affected

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then change the color from Orange to Magenta

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed typo

Comment thread database/worlds.sql Outdated
@anishk85
anishk85 force-pushed the quadrotor-colorv2 branch from 7c19e9b to b9ad8f3 Compare July 23, 2026 16:44
@anishk85

Copy link
Copy Markdown
Collaborator Author

hi @javizqh can we merge this ?

i am pushing small prs so it we can move quickly.

@anishk85

Copy link
Copy Markdown
Collaborator Author

my next pr will be on adding three worlds and one mouse behaviour for each world that is dependent on this.
i have to start work on that too.

@javizqh

javizqh commented Jul 24, 2026

Copy link
Copy Markdown
Member

This affects the other drones. This must be fixed before merging

Screenshot From 2026-07-24 12-08-21

@javizqh

javizqh commented Jul 24, 2026

Copy link
Copy Markdown
Member

The original color is Orange

@anishk85

Copy link
Copy Markdown
Collaborator Author

The original color is Orange

yeah i will fix this it was not related to db it's because in the drone xacro i made default color blue so if any excersice dont provide any color it receives blue only. i will change this to orange

@javizqh javizqh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test changes before submitting

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you still default to Blue

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thanks for pointing out.
sorry for not testing it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also noticed that i didn't defined magenta here it was defined in another branch this created a confusion

@anishk85
anishk85 force-pushed the quadrotor-colorv2 branch from b98c141 to 471f197 Compare July 24, 2026 11:20
@javizqh
javizqh merged commit 0b76397 into JdeRobot:humble-devel Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants