Stop reporting cancelled runs as failures - #16
Merged
Conversation
A run that was stopped by hand, or killed by a concurrency group when a newer push superseded it, carries no verdict about the branch - and `stale` means it never really ran. Both were being counted as red, so a repo turned red for the sole reason that somebody cancelled a job. Cancelled and stale runs are now skipped when picking each workflow's latest run, so the workflow keeps showing its last real verdict. The targeted per-workflow fetch asks for five runs instead of one, because the newest may be the cancelled one and the API has no filter for it. A workflow whose only runs are cancelled is absent from the exposition rather than red, which reads the same as a workflow that never ran. Pull requests follow the same rule: only `failure` counts as failing. The PR table still shows "cancelled" in its checks column, and both dashboards drop it from the failing-PR panels. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run that was stopped by hand, or killed by a concurrency group when a newer push superseded it, carries no verdict about the branch — and
stalemeans it never really ran. Both were counted as red, so a repo went red for the sole reason that somebody cancelled a job.What changes
jq_ci_last_run*is not emitted for a repo whose only run was cancelled.failurecounts towardjq_open_pull_requests_failing. The PR table still showscancelledin its checks column, so the information isn't lost — it just doesn't read as red.cancelledfrom the failing-PR panel queries.Testing
pytest— 51 passed. Six new tests cover the fallback to the last conclusive run, the absent-not-red case on both layers, the multi-run direct fetch, and the PR count.🤖 Generated with Claude Code