feat: a folder entry can exclude a checkout by name - #33
Merged
Conversation
A folder is only usable for a directory that is *entirely* yours, and the one
in front of me was not: ~/repos/jebel-quant held 26 of my own repos and a clone
of upstream numpy, which has no business on a fleet board - its own PR budget,
a line count of a tree that size read through the Docker mount, a template
drift column for a repo that never heard of the template. Listing 26 repos to
leave out the 27th is the terseness the folder entry was for.
- folder: ~/repos/jebel-quant
exclude: [numpy]
Excludes name the folder's own subdirectories. That is the one thing about a
child that is knowable without reading its git config, and the thing you see
when you list the folder - and the two do come apart: ~/repos/tschm/
rhiza_projects/funnel is VanekPetr/funnel. So which of the two is meant had to
be settled rather than guessed, and an `owner/name` written there is refused
rather than quietly matching nothing.
The interesting decision is what a spent exclude does. Every other mistake in
repos.yml is fatal, and this one is a warning, because the harm the refusals
guard against is a repo silently *missing* from the board. An exclude exists to
keep a repo off it, so a folder with no such checkout in it already satisfies
the request: the outcome is the one the file asked for and only the line is
spent. That is what deleting a clone you never wanted looks like - a normal
thing to do, which must not take the board down.
It is also what a misspelt exclude looks like, and that one does put an
unwanted repo on the board, so it is logged. But it lands as a row you can see
next to the warning, not as the absent row you notice weeks later, and that is
the difference between the two.
Written after `numpy` was deleted from that folder mid-change and the
first draft, which refused, would have stopped the collector over a directory
whose removal was the point.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #32. A folder entry is only usable for a directory that is
entirely yours, and the one in front of me was not:
~/repos/jebel-quantheld 26 of my own repos and a clone of upstream numpy. Listing 26 repos to
leave out the 27th is exactly the terseness
folder:was meant to remove.A single name needs no brackets.
Excludes name directories
That is the one thing about a child that is knowable without reading its git
config, and the thing you see when you list the folder. The two really do come
apart —
~/repos/tschm/rhiza_projects/funnelisVanekPetr/funnel— so whichof the two is meant had to be settled rather than guessed. An
owner/namewritten there is refused rather than quietly matching nothing.
A spent exclude warns, and does not refuse
Every other mistake in
repos.ymlis fatal. This one is not, and the asymmetryis the point of the change:
board.
checkout in it already satisfies that request — the outcome is the one the
file asked for, and only the line is spent. That is what deleting a clone you
never wanted looks like: a normal thing to do, which must not take the board
down.
unwanted repo on the board — so it is logged. But it lands as a row you can
see next to the warning, not as the absent row you notice weeks later.
excludeon an entry that is not a folder is refused: one repo has nothingto exclude from, and reading the key as decoration would leave you believing a
repo was off the board while it sat on it.
The first draft of this refused a spent exclude.
numpywas then deleted fromthat folder mid-change, and the refusal would have stopped the collector over a
directory whose removal was the whole point — hence the rule above.
Verification
repos.pyat 100% statement coverage; ruff check and formatclean.
repos.ymlwent from 27 entries to 5 (three foldersand two paths), and the fleet went 27 → 38 repos with nothing dropped —
10 more
Jebel-Quant/*,tschm/cvxball, andtschm/pyhrpgaining thecheckout it turned out to have all along.
🤖 Generated with Claude Code