Skip to content

chore: add CODEOWNERS so the ruleset's code-owner review has something to match - #61

Merged
tschm merged 1 commit into
mainfrom
codeowners
Aug 9, 2026
Merged

chore: add CODEOWNERS so the ruleset's code-owner review has something to match#61
tschm merged 1 commit into
mainfrom
codeowners

Conversation

@tschm

@tschm tschm commented Aug 9, 2026

Copy link
Copy Markdown
Member

Adds .github/CODEOWNERS with a single catch-all owner.

Why

The main-branch-protection ruleset (applied to this repo today, id 20598569) sets require_code_owner_review: true. With no CODEOWNERS file anywhere in the repo, that rule matched nothing and was silently inert — it looked like a protection and enforced nothing. This gives it something to match.

What it does and doesn't change

  • Doesn't change how release PRs merge today. A code owner cannot approve their own pull request, so on a single-maintainer repo the rule is unsatisfiable by the author and a release PR still merges via the ruleset's admin bypass — exactly as before this file existed.
  • Does make the rule real the moment a second maintainer exists, with no further configuration.

Placement

.github/CODEOWNERS is not in .rhiza/template.lock, unlike the 23 other .github/ files rhiza manages (workflows, issue templates, the ruleset JSONs). So this is repo-owned and the next /rhiza:update will not overwrite it.

The comment block in the file records the last-match-wins ordering rule, so narrower entries added later go below the catch-all rather than above it.

Copilot AI lite review requested due to automatic review settings August 9, 2026 02:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a repository-owned .github/CODEOWNERS file so the existing branch protection ruleset option require_code_owner_review: true has an actual match target and therefore becomes enforceable when additional maintainers exist.

Changes:

  • Add .github/CODEOWNERS with a catch-all (*) mapping to a single owner (@tschm).
  • Document CODEOWNERS matching/precedence behavior and the single-maintainer limitation directly in the file comments.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tschm
tschm merged commit 96d24bd into main Aug 9, 2026
61 checks passed
@tschm
tschm deleted the codeowners branch August 9, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants