feat: add a flag to be read from yaml to choose if the start time is … #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Plx
requested review from
baltzell,
efuchey,
mathieuouillon and
mpaolone
as code owners
Closed
Collaborator
Author
|
@mathieuouillon This is a fix to avoid requiring the start time for hit reading, with a flag UseStartTime that can be "true" or "false" (quotation marks are important) in the yaml, if you want to test it on simulations that'd be great! |
Collaborator
|
The fix works, thanks. The YAML flag works fine also. |
mathieuouillon
approved these changes
Sep 30, 2025
Collaborator
mathieuouillon
left a comment
mathieuouillon
left a comment
There was a problem hiding this comment.
Look good for me. Work with simulation.
CI build job was failing due to a Maven server-side misconfiguration; this run should succeed.
tongtongcao
pushed a commit
that referenced
this pull request
Nov 18, 2025
tongtongcao
pushed a commit
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…used or ignored