Skip to content

feat: add a flag to be read from yaml to choose if the start time is … #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

feat: add a flag to be read from yaml to choose if the start time is … #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c6f212
feat: add a flag to be read from yaml to choose if the start time is …
N-Plx Sep 29, 2025
52f93a8
ci: re-trigger
c-dilks Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...constants/CalibrationConstantsLoader.java → ...constants/CalibrationConstantsLoader.java
View file
Open in desktop
File renamed without changes.
3 changes: 1 addition & 2 deletions reconstruction/alert/src/main/java/org/jlab/rec/atof/hit/HitFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public void setWedgeHits(ArrayList<ATOFHit> wedge_hits) {
* @param atof the {@link Detector} representing the atof geometry to match
* the sector/layer/component to x/y/z.
*/
public void findHits(DataEvent event, Detector atof) {
public void findHits(DataEvent event, Detector atof, float startTime) {
//For each event a list of bar hits and a list of wedge hits are filled
this.barHits.clear();
this.wedgeHits.clear();
Expand All @@ -72,7 +72,6 @@ public void findHits(DataEvent event, Detector atof) {
//Check that the event start time is defined are done in the engine
//if (event.hasBank("REC::Event") &&
// event.getBank("REC::Event").getFloat("startTime", 0)!=-1000)
float startTime = event.getBank("REC::Event").getFloat("startTime", 0);

int nt = bank.rows(); // number of hits
//Hits in the bar downstream and upstream will be matched
Expand Down
35 changes: 23 additions & 12 deletions reconstruction/alert/src/main/java/org/jlab/service/atof/ATOFEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package org.jlab.service.atof;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
import java.util.logging.Logger;

import org.jlab.clas.reco.ReconstructionEngine;
import org.jlab.io.base.DataBank;
Expand Down Expand Up @@ -38,6 +38,8 @@ public ATOFEngine() {

private Detector ATOF;
private double b; //Magnetic field
private boolean useStartTime = true;
static final Logger LOGGER = Logger.getLogger(ATOFEngine.class.getName());

public void setB(double B) {
this.b = B;
Expand All @@ -56,15 +58,20 @@ public Detector getATOF() {

@Override
public boolean processDataEvent(DataEvent event) {

if (!event.hasBank("RUN::config")) {
return true;
}

//This assumes the FD reconstruction produced an event with good startTime
//All start time handling could be moved as an EB-type step later
if (!event.hasBank("REC::Event") || event.getBank("REC::Event").getFloat("startTime", 0)==-1000) {
return true;
float startTime = 0;
if(useStartTime)
{
//This assumes the FD reconstruction produced an event with good startTime
//All start time handling could be moved as an EB-type step later
if (!event.hasBank("REC::Event")) {
LOGGER.severe("REC::Event bank could not be read in ATOF engine while requestign starttime");
return true;
}
//Deal with FT TODO : if(event.getBank("REC::Event").getFloat("startTime", 0)==-1000)
else startTime = event.getBank("REC::Event").getFloat("startTime", 0);
}

DataBank bank = event.getBank("RUN::config");
Expand Down Expand Up @@ -98,7 +105,7 @@ public boolean processDataEvent(DataEvent event) {
// Why do we have to "find" hits?
//Hit finder init
HitFinder hitfinder = new HitFinder();
hitfinder.findHits(event, ATOF);
hitfinder.findHits(event, ATOF, startTime);

ArrayList<ATOFHit> WedgeHits = hitfinder.getWedgeHits();
ArrayList<BarHit> BarHits = hitfinder.getBarHits();
Expand Down Expand Up @@ -149,15 +156,19 @@ public boolean init() {
}

requireConstants(tableMap);

this.getConstantsManager().setVariation("default");

this.registerOutputBank("ATOF::hits", "ATOF::clusters");

String useStartTimeString = "UseStartTime";
if(this.getEngineConfigString(useStartTimeString)!=null) {
if ("true".equals(this.getEngineConfigString(useStartTimeString)))
this.useStartTime = true;
else if ("false".equals(this.getEngineConfigString(useStartTimeString)))
this.useStartTime = false;
else {LOGGER.severe("Invalid option parsed for ATOF UseStartTime"); return false;}
}
return true;
}

public static void main(String arg[]) {

}
}