chore: re-render managed files with @j4k/align@1.82.1#39
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Fix a documentation-vs-code contradiction and a dangling config entry that surfaced during the align re-render review: - README stated Node >= v22.19.0 while package.json engines is >=24.0.0; a Node 22 install would hit EBADENGINE. Align the README to v24.0.0. - knip.json entry still listed the now-deleted types/css-modules.d.ts, leaving a permanent "no matches" configuration hint. Drop it; entry is repo-owned (the aligner only manages $schema/ignore/github-actions).
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical re-render of managed files with
@j4k/align@1.82.1(provider: github), plus two small review-driven cleanups.Re-render: the only managed-file change is the removal of the now-forbidden
types/css-modules.d.tsshim — the 1.82.x css-modules shim gating drops it from non-CSS-modules repos, and the aligner moved it to trash.Review-driven fixes (repo-owned files):
README.md: corrected the stated Node requirement fromv22.19.0tov24.0.0, matchingpackage.jsonengines.node(>=24.0.0). A Node 22 install would otherwise hitEBADENGINErather than the documented supported install.knip.json: dropped the now-deletedtypes/css-modules.d.tsfrom theentryarray, silencing the permanent non-fatal "no matches" configuration hint. Theentrylist is repo-owned — the aligner only manages$schema/ignore/github-actions(seeknip-json-schema.ts) — so this edit is stable across future align runs.Node Floor is advisory only (
engines.node ">=24.0.0"below the">=24.15.0"floor) — the aligner does not auto-fix it for a public package, soenginesis intentionally left untouched here.Gates run locally against this diff, all green:
pnpm install,lint,typecheck,format:check,knip(now zero hints),test(115 passed),fta.