fix(ship): run security checks for all workspaces - #1059
Merged
Conversation
…ted paths - Add cross-cutting security audit step (Step 4) that always runs for all workspaces (codingbuddy, codingbuddy-claude-plugin, landing-page) when any workspace has changes, matching CI behavior - Add --full flag to run ALL workspace checks locally (matches CI exactly) - Update docs-only fast path to respect --full flag override - Renumber steps to accommodate new security check step Closes #979
JeremyDev87
added
bug
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Mar 28, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVED ✅
Excellent implementation of #979. Key changes:
- Cross-cutting security (Step 4):
npm audit --severity highnow runs for ALL workspaces regardless of affected paths — directly fixes the root cause --fullflag: Clean argument parsing, marks all workspaces as affected- Docs-only fast path preserved: Skips CI including security only when
--fullis NOT set - Step renumbering: Consistent and correct (4→5, 5→6, 6→7, 7→8, 8→9)
- Report updated: Includes security status and
--fullmode indicator
No critical or high issues. Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm audit --severity highfor all workspaces (codingbuddy,codingbuddy-claude-plugin,landing-page) when any workspace has changes — matching CI behavior where all security jobs run on every triggered push--fullflag to/shipthat runs ALL workspace checks locally, exactly matching CI--fullflag overrideTest plan
/shipon a change touching onlyapps/mcp-server/— verify security checks run for all 3 workspaces, not justcodingbuddy/ship --full— verify all workspace checks (lint, format, typecheck, test, build) run for all workspaces/shipon a docs-only change — verify all checks (including security) are skipped/ship --fullon a docs-only change — verify all checks run despite no matching workspaceCloses #979