[Test] BigQuery DESTINATION change (expect: labeled)#4
Open
Jeremyyang920 wants to merge 5 commits into
Open
Conversation
Signal deprecation of the Snowflake, BigQuery, ElasticSearch, Kafka (incl. Confluent/Redpanda), Azure Event Hubs, and Google Pub/Sub destination connectors. No code is removed; these remain fully functional. Actively-maintained paths are Postgres -> ClickHouse, Postgres -> ClickHouse Cloud, and Postgres -> Postgres. - README: deprecation notice + connector status matrix - docs/DEPRECATED_CONNECTORS.md: pin + fork migration guide - CONTRIBUTING.md: links to the migration guide - UI: "Deprecated" badge in the peer creation flow - Issue form with a destination-connector dropdown + deprecation notice - labeler.yml + workflow: label deprecated-connector PRs/issues and post a one-time notice (never auto-closes) Refs PeerDB-io#4465 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
BigQuery is a supported QRep source, so a blanket "Deprecated" badge is inaccurate. Model deprecation per role: BigQuery is deprecated only as a destination and stays a supported source. - UI: add deprecatedRole to peer-types; badge reads "Deprecated as destination" for BigQuery, "Deprecated" for the others - README: note destination-only scope; add BigQuery as a maintained source - docs/DEPRECATED_CONNECTORS.md: clarify BigQuery destination-only - Issue template + workflow notice: same clarification Refs PeerDB-io#4465 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Move the connector deprecation notice in the README to just after the intro (before "Get started") for visibility, linking to the status matrix. - Peer-creation grid: uniform "Deprecated" badge; mark destination-only deprecations (BigQuery) with an asterisk + a footnote. - Rename docs/DEPRECATED_CONNECTORS.md -> docs/deprecated-connectors.md to match the docs/ naming convention; update all references. Refs PeerDB-io#4465 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- labeler.yml: BigQuery is dual-role (source maintained, destination deprecated) and its source/destination code share one directory. Match BigQuery paths only when no BigQuery *source* file is in the change (source.go, source_schema.go, qrep_object_pull.go, bigquery_source_test.go), using the documented all: + all-globs-to-all-files negation. Destination-only connectors keep their simple globs. - deprecated-connector.yml: add `needs: label` + `if: always()` to the notice job so on pull_request_target it runs after the labeler applies the label (the labeler's GITHUB_TOKEN write does not emit a `labeled` event), fixing both the race and the never-posted-notice bug. Refs PeerDB-io#4465 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Jeremyyang920
force-pushed
the
deprecate-non-ch-pg-destinations
branch
2 times, most recently
from
58a79ad to
8c02950
Compare
Jeremyyang920
force-pushed
the
deprecate-non-ch-pg-destinations
branch
from
8c02950 to
41f25b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated test of the deprecated-connector labeler/notice workflow.