fix: name pre-commit template .pre-commit-config.yaml - #4
Merged
Conversation
pre-commit only discovers `.pre-commit-config.yaml` by default. The synced template was called `.pre-commit-config.yml`, so target repos without their own config (keras-complex) failed the "Pre-commit Checks" workflow with "`.pre-commit-config.yaml is not a file`". Renaming the template fixes the sync output; the labeler config already referenced the `.yaml` name. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GqGvtFsaGKvFTGMNcJpSek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The synced PR in keras-complex (JesperDramsch/keras-complex#25) fails the "Pre-commit Checks" workflow with:
pre-commit only auto-discovers
.pre-commit-config.yaml. The template in this repo was named.pre-commit-config.yml, so any target repo that relies on the synced file gets a config pre-commit never reads. python-deadlines passes only because it already carries its own.yaml.Change
Pure rename, no content change:
configs/labeler.ymlalready referenced the.yamlname, so this also makes the repo self-consistent.Not covered here
The other red jobs on the keras-complex sync PR (black formatting, tests failing against Keras 3) are breakage inside keras-complex itself, not in these templates.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GqGvtFsaGKvFTGMNcJpSek
Generated by Claude Code