fix e2e tests performance#162
Merged
JesperDramsch merged 2 commits intomainfrom Jan 4, 2026
Merged
Conversation
- Add explicit Jekyll build step before serve to fix failing tests - Remove --incremental flag which caused empty site in CI - Replace all waitForTimeout() calls with proper DOM-based waits - Reduce waitForCountdowns timeout from 10s to 5s - Replace networkidle with domcontentloaded for faster page loads - Reduce wait-on server timeout from 30s to 15s These changes should significantly reduce E2E test runtime and fix the 64 failing tests caused by serving an unbuilt site.
Reduces workflow build time by eliminating 4 redundant Jekyll builds. Previously each of the 5 jobs (3 browser matrix + mobile + visual) built the site independently. Now: - A dedicated `build` job builds Jekyll once and uploads _site as artifact - All test jobs download the pre-built artifact instead of rebuilding - Test jobs use `serve` to host static files (no Ruby needed) - Removes Ruby setup from test jobs entirely This should cut the overall workflow time significantly since Jekyll build is the most time-consuming step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.