[codex] perf(components): drop zod from browser client form

[Jesssullivan]

What Changed

• replaced zod-based browser validation in ClientForm.svelte with lightweight inline field checks
• updated the pure logic ClientForm test file to match the new validation contract
• bumped @tummycrypt/scheduling-kit release metadata from 0.7.0 to 0.7.1

Why

ClientForm.svelte is a browser component, but it was importing full zod runtime validation for only three fields: first name, last name, and email. In a clean MassageIthaca build, that pulled a vendor-zod client chunk of 113.87 kB into the booking graph.

A throwaway app-level proof build showed that removing the zod import from the browser ClientForm removes that vendor-zod chunk entirely from the client output.

Impact

• reduces client bundle weight on booking surfaces that render ClientForm
• keeps the same user-visible validation messages for required names and email format
• does not change public package APIs

Validation

• pnpm exec vitest run src/tests/components/client-form.test.ts
• pnpm exec vitest run --config vitest.component.config.ts tests/e2e/client-form.test.ts
• pnpm run check:release-metadata
• pnpm build

Refs #44

[greptile-apps]

Greptile Summary

This PR removes the zod runtime import from ClientForm.svelte, replacing three-field schema validation with lightweight inline regex/trim checks, and bumps the package version from 0.7.0 to 0.7.1 across package.json, BUILD.bazel, and MODULE.bazel. Zod is retained as a production dependency for server-side core modules (pipelines.ts, utils.ts) where tree-shaking prevents it from entering the browser bundle.

Confidence Score: 5/5

Safe to merge — the inline validation is functionally equivalent for all reachable UI states, and zod is correctly retained only for server-side code.

All findings are P2: a test/component divergence in intake radio strictness and mismatched error-message strings in the test helper. Neither affects runtime behavior reachable through the UI. No security issues, no breaking API changes, and the bundle-size goal is achieved.

src/tests/components/client-form.test.ts — the re-implemented validateIntake helper tests stricter invariants than the component enforces and uses different error message strings.

Important Files Changed

Filename	Overview
src/components/ClientForm.svelte	Replaces zod schema validation with inline trim/regex checks; logic is correct and equivalent for the UI's constrained input paths.
src/tests/components/client-form.test.ts	Test re-implements the component's pure logic, but the inline validateIntake uses a stricter radio check (!== 'yes' && !== 'no') than the component (!painRadio), and the error messages don't match the component's user-visible strings.
package.json	Version bumped to 0.7.1; zod remains a production dependency (expected, used by server-side core modules).
BUILD.bazel	Version field in the npm_package target updated to 0.7.1; no functional build changes.
MODULE.bazel	Module version bumped to 0.7.1; no other changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Form Submit] --> B[validate]
    B --> C{firstName.trim empty?}
    C -- yes --> D[errors.firstName = 'First name is required']
    C -- no --> E{lastName.trim empty?}
    D --> E
    E -- yes --> F[errors.lastName = 'Last name is required']
    E -- no --> G{email empty or regex fails?}
    F --> G
    G -- yes --> H[errors.email = 'Please enter a valid email address']
    G -- no --> I{showIntakeFields?}
    H --> I
    I -- yes --> J[Validate painRadio / clenching / headaches / howDidYouHear / medication / termsAccepted]
    J --> K{errors empty?}
    I -- no --> K
    K -- no --> L[Return early — show inline errors]
    K -- yes --> M[Build ClientInfo]
    M --> N[onSubmit callback]

Loading

Comments Outside Diff (2)

1. src/tests/components/client-form.test.ts, line 61-68 (link)

   Test validateIntake is stricter than the component

   The test's radio check (fields.painRadio !== 'yes' && fields.painRadio !== 'no') rejects any non-yes/no string (e.g. 'maybe'), but the component's actual validate() only tests falsiness (!painRadio), which would accept any truthy value. For the current UI this doesn't matter — the radio inputs can only produce '', 'yes', or 'no' — but the tests are asserting stronger invariants than the component enforces, which can mislead future contributors about the real validation contract.

   Consider aligning one of them: either tighten the component check to painRadio !== 'yes' && painRadio !== 'no', or loosen the test to match the !painRadio truthiness check.

2. src/tests/components/client-form.test.ts, line 59-80 (link)

   Test error messages don't match user-visible component strings

   The validateIntake helper returns strings like 'Pain question is required' and 'You must accept the terms', but the component emits 'Please answer this question' and 'You must accept the terms to continue'. Because this test file re-implements the logic rather than exercising the component directly, none of the user-visible intake error messages are actually covered by tests. If the wording changes in the component, the tests stay green regardless.

_{Reviews (1): Last reviewed commit: "perf(components): drop zod from browser ..." | Re-trigger Greptile}