chore!: Remove unused R2dbcPreparedStatementApi methods - #2683
Merged
Chantal Loncle (bog-walk) merged 1 commit intoDec 12, 2025
Conversation
- Remove closeIfPossible() & cancel(), as they do nothing and have no relevant Statement methods available. - Rename closeExecutedStatements() to clearExecutedStatements() & no longer needs to suspend
Chantal Loncle (bog-walk)
requested review from
Leonid Stashevsky (e5l) and
obabichevjb
December 8, 2025 02:21
6 tasks
obabichevjb
approved these changes
Dec 9, 2025
Chantal Loncle (bog-walk)
deleted the
bog-walk/drop-unused-r2dbc-api-methods
branch
December 12, 2025 01:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
.closeIfPossible()&.cancel()fromR2dbcPreparedStatementApiinterfaceR2dbcTransaction.closeExecutedStatements()to.clearExecutedStatements()& dropsuspendDetailed description:
closeIfPossible()andcancel()implementation in R2DBC is empty, because there are noio.r2dbc.spi.Statementapi for cancelling/closing. Unlike JDBC, for which this exists, the concept of closing/cancelling is entirely dependent on its execution and the consumption of the results.closeExecutedStatements()calledcloseIfPossible(), so the rename is more honest about the actual behaviorMono, the better the implementation.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist