Skip to content

Support multiplatform BackHandler/PredictiveBackHandler. - #1771

Merged
Konstantin (terrakok) merged 5 commits into
jb-mainfrom
k.tskh/ios-back-gesture
Jan 21, 2025
Merged

Support multiplatform BackHandler/PredictiveBackHandler.#1771
Konstantin (terrakok) merged 5 commits into
jb-mainfrom
k.tskh/ios-back-gesture

Conversation

@terrakok

@terrakok Konstantin (terrakok) commented Jan 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Support BackHandler/PredictiveBackHandler.

Fixes https://youtrack.jetbrains.com/issue/CMP-4419

Screen.Recording.2025-01-10.at.21.19.40.mov

Testing

  • Test it on a demo project

Release Notes

Highlights - Multiple Platforms

  • Implement multiplatform BackHandler and PredictiveBackHandler. And use them in material3 widgets and androidx-navigation library.

MatkovIvan
Ivan Matkov (MatkovIvan) reviewed Jan 10, 2025
View reviewed changes
Comment thread ...ial3/material3/src/uikitMain/kotlin/androidx/compose/material3/internal/BackHandler.uikit.kt Outdated
Comment thread compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/App.kt
Comment thread compose/mpp/demo/src/uikitMain/kotlin/androidx/compose/mpp/demo/UIKitPredictiveBackExample.kt
Comment thread compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitBackEvent.kt Outdated
Comment thread ...ose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitPredictiveBackHandler.kt Outdated
Comment thread .../src/commonMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.kt
Comment thread ...topMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.desktop.kt Outdated
Comment thread ...macosMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.macos.kt Outdated
Comment thread ...uikitMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.uikit.kt
Comment thread ...src/webMain/kotlin/androidx/navigation/compose/internal/PlatformPredictiveBackHandler.web.kt Outdated
MatkovIvan
Ivan Matkov (MatkovIvan) requested changes Jan 13, 2025
View reviewed changes

@MatkovIvan Ivan Matkov (MatkovIvan) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that adding it to skikoMain is the right move at the moment. We DO want to make common API for this, but not in compose-ui module

Comment thread compose/material3/material3/build.gradle Outdated
Comment thread compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/backhandler/BackEventCompat.kt Outdated
Comment thread navigation/navigation-compose/build.gradle Outdated
@terrakok Konstantin (terrakok) mentioned this pull request Jan 16, 2025
Closed
@terrakok Konstantin (terrakok) changed the title K.tskh/ios back gesture Support BackHandler/PredictiveBackHandler. Jan 16, 2025
@terrakok Konstantin (terrakok) changed the title Support BackHandler/PredictiveBackHandler. Support multiplatform BackHandler/PredictiveBackHandler. Jan 16, 2025
MatkovIvan
Ivan Matkov (MatkovIvan) requested changes Jan 17, 2025
View reviewed changes
Comment thread ...ose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
Comment thread ...ose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt Outdated
Comment thread compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Comment thread ...material3/material3/src/commonMain/kotlin/androidx/compose/material3/internal/BackHandler.kt
Comment thread ...ui-backhandler/src/androidMain/kotlin/androidx/compose/ui/backhandler/BackHandler.android.kt
Comment thread ...e/ui/ui-backhandler/src/commonMain/kotlin/androidx/compose/ui/backhandler/BackEventCompat.kt Outdated
Comment thread compose/ui/ui-backhandler/src/jbMain/kotlin/androidx/compose/ui/backhandler/BackHandler.jb.kt Outdated
ASalavei
Andrei Salavei (ASalavei) reviewed Jan 17, 2025
View reviewed changes
Comment thread ...ose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitBackGestureDispatcher.kt Outdated
Comment thread ...ose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitBackGestureDispatcher.kt
Comment thread ...ose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/backhandler/UIKitBackGestureDispatcher.kt Outdated
@terrakok
Konstantin (terrakok) force-pushed the k.tskh/ios-back-gesture branch 2 times, most recently from 5653ec4 to 1cd1470 Compare January 17, 2025 16:19
@terrakok
Konstantin (terrakok) force-pushed the k.tskh/ios-back-gesture branch 2 times, most recently from bcdb1ba to 15aa84a Compare January 17, 2025 17:59
MatkovIvan
Ivan Matkov (MatkovIvan) reviewed Jan 21, 2025
View reviewed changes

@MatkovIvan Ivan Matkov (MatkovIvan) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from changes in material common, LGTM

Comment thread compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt Outdated
@terrakok
Konstantin (terrakok) merged commit 00374fd into jb-main Jan 21, 2025
@terrakok
Konstantin (terrakok) deleted the k.tskh/ios-back-gesture branch January 21, 2025 17:41
@terrakok Konstantin (terrakok) mentioned this pull request Jan 24, 2025
Open
@JetBrains JetBrains (JetBrains) locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MatkovIvan Ivan Matkov (MatkovIvan) MatkovIvan requested changes
@ASalavei Andrei Salavei (ASalavei) ASalavei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terrakok @MatkovIvan @ASalavei