[JEWEL-491] Remove unneeded composable annotation#2997
Closed
rock3r wants to merge 1 commit intoJetBrains:masterfrom
Closed
[JEWEL-491] Remove unneeded composable annotation#2997rock3r wants to merge 1 commit intoJetBrains:masterfrom
rock3r wants to merge 1 commit intoJetBrains:masterfrom
Conversation
Since JEWEL-490, standalone styling default factories do not include text styles any longer. Text styles were the only reason we needed these factories to be composable. In the meantime, some factories had dropped the composable annotation, but most hadn't. This brings them all in line by dropping the annotation everywhere. Small fix included: SimpleListItemStyle uses JewelTheme.isDark instead of isSystemInDarkMode(), which was technically wrong (the theme can be dark even if the system is not in dark mode).
hamen
approved these changes
Mar 24, 2025
Contributor
hamen
left a comment
hamen
left a comment
There was a problem hiding this comment.
Nice clean up.
Tested on Windows11: Standalone and IDE ✅
Collaborator
Author
|
Ready to merge |
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
Since JEWEL-490, standalone styling default factories do not include text styles any longer. Text styles were the only reason we needed these factories to be composable. In the meantime, some factories had dropped the composable annotation, but most hadn't. This brings them all in line by dropping the annotation everywhere. Small fix included: SimpleListItemStyle uses JewelTheme.isDark instead of isSystemInDarkMode(), which was technically wrong (the theme can be dark even if the system is not in dark mode). closes #2997 (cherry picked from commit 271fbe5530d3b5d2d20f0b7d01e7aaab687a770b) (cherry picked from commit b20ac746e9e6430a2ac807a7ebd28056a0d51115) IJ-MR-158649 GitOrigin-RevId: 9de2af25bd7c28fc746e60e542d56a79358ccaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since JEWEL-490, standalone styling default factories do not include text styles any longer. Text styles were the only reason we needed these factories to be composable.
In the meantime, some factories had dropped the composable annotation, but most hadn't. This brings them all in line by dropping the annotation everywhere.
Small fix included: SimpleListItemStyle uses
JewelTheme.isDarkinstead ofisSystemInDarkMode(), which was technically wrong (the theme can be dark even if the system is not in dark mode).