[JEWEL-792] Add slot-based API for InlineBanner #3012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jewel/samples/showcase/components/Banners.kt Co-authored-by: Sebastiano Poggi <rock3r@users.noreply.github.com>
Collaborator
Author
|
@hamen you can review the last commit only, until the base PR is merged that's the only difference |
hamen
approved these changes
Apr 1, 2025
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InlineBanner.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InlineBanner.kt
Show resolved
Hide resolved
This adds a slot-based API to InlineBanner, in addition to the String-based API that already exists. It is a non-breaking change. The reason is to allow users to specify their own main content, e.g., to use Markdown. The title is unaffected as it remains plain text. Additionally, this fixes the KDoc for InlineBanner by making sure there is no content after the tags section. Before this all the content after the last tag would be considered to be part of the tag itself's documentation, which is incorrect. The KDoc have also been rewritten for correctness and to improve clarity, making them simpler and more readable.
rock3r
force-pushed
the
sebp/JEWEL-792_markdown-text-in-banners
branch
from
0079b9f to
f094744
Compare
Collaborator
Author
|
ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a slot-based API to InlineBanner, in addition to the String-based API that already exists. It is a non-breaking change. The reason is to allow users to specify their own main content, e.g., to use Markdown. The title is unaffected as it remains plain text.
Important
This PR needs #2999 to be merged first
Additionally, this fixes the KDoc for InlineBanner by making sure there is no content after the tags section. Before this all the content after the last tag would be considered to be part of the tag itself's documentation, which is incorrect.
The KDocs have also been rewritten for correctness and to improve clarity, making them simpler and more readable.