Add type compiler validation tests for GitHubUserValidator

[atul-upadhyay-7]

Description

Closes #2962

Adds type-level compiler tests for the GitHubUserValidator class in services/github/validate-user.ts. The test file uses Vitest's expectTypeOf to verify the public API signatures of validateUser, getInstance, and reset methods, including negative type assertions that ensure non-string types are not accepted by validateUser.

Pillar

• 🛠️ Other (Test coverage for type compiler validation)

What changed

• Added services/github/validate-user.type-compiler.test.ts with 5 test cases:
  • Parameter and return type assertions for validateUser
  • Singleton instance pattern type verification for getInstance
  • Return type verification for reset method (void)
  • Negative type assertions ensuring only strings are accepted
  • Schema validation constraints return type verification

Checklist before requesting a review:

• I have read the CONTRIBUTING.md file.
• I have tested these changes locally (npx vitest run services/github/validate-user.type-compiler.test.ts).
• I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
• My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
• I have made sure that I have only one commit to merge in this PR.

[vercel]

@atul-upadhyay-7 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

👋 Hey @atul-upadhyay-7, it looks like you didn't use our PR template!

The section ## Description is missing from your PR description.

Please update your PR description to include all required sections so we can review this properly:

• ## Description — What does this PR do? Which issue does it fix?
• ## Pillar — Which contribution pillar does this fall under?
• ## Checklist — Have you ticked off the quality checklist?

You can find the full template in CONTRIBUTING.md. Just edit your PR description and the needs-details label will be removed automatically. 🙌

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds type-level compiler tests for the GitHubUserValidator class to verify its public API signatures using vitest's expectTypeOf.

Changes:

• Adds type assertions for validateUser parameters and return type.
• Adds type assertions for the getInstance singleton and reset method.
• Adds negative type assertions ensuring non-string types are not accepted.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[atul-upadhyay-7]

@JhaSourav07 Hi! I've updated PR #3098 to address the issues.

What I fixed:

1. ✅ PR description - Completely rewrote the description to match the required template with all sections (## Description, ## Pillar, ## Checklist). The needs-details label has been automatically removed by the bot.

2. ✅ Branch rebased - Rebased onto the latest upstream main (now at 2e604a1) to resolve the check-conflicts failure. The branch is now up to date.

3. ❓ type:bug label - This label appears to have been incorrectly applied. This PR adds type-level compiler tests for GitHubUserValidator (issue test(validate-user-type-compiler): verify TypeScript Compiler Validation & Schema Constraints Stability (Variation 10) #2962) — it's a test addition, not a bug fix. Could you please review and remove this label if appropriate? This is an automated label and not something I can remove myself.

Current CI status:

• Format · Lint · Typecheck · Test — passing
• Production Build — passing
• check-conflicts — should now pass after rebase
• Verify PR is Linked to an Assigned Issue — needs investigation
• Vercel — requires your authorization to deploy (not contributor-fixable)

Summary of changes:

• Added services/github/validate-user.type-compiler.test.ts with 5 test cases using expectTypeOf to verify the public API signatures of validateUser, getInstance, and reset methods
• Followed the type-compiler test pattern from the repository

Could you please:

1. Remove the type:bug label (it's incorrect)
2. Authorize the Vercel deployment

Thanks!

[atul-upadhyay-7]

@JhaSourav07 could you review this

[github-actions]

🎉 Congratulations @atul-upadhyay-7! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨