fix: hide feedback icon when logged out - #36
Merged
Conversation
The feedback IconButton in the home screen app bar was shown to all users, including logged-out ones. Wrap it in an AuthService.isLoggedIn guard so it only appears for authenticated users, matching the pattern used by the admin action below it.
✅ Deploy Preview for lively-torte-533cc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Jmangles
pushed a commit
that referenced
this pull request
Jul 16, 2026
* Add reusable local Supabase dev stack (#31) Use declarative schemas for future migrations * chore: Remove delete grant (#32) * fix: Mirror actual prod state of tricks in local db (#35) * feat: Port consistency slider from old Highline Freestyle app (#28) * feat: Port consistency slider from old Highline Freestyle app * fix: Make sure first and last label in consistency slider have enough padding from the edges of the screen * fix: Use declarative schema * chore: Add delete-trick grant (#34) * Allow users to provide feedback (#29) * feat (Draft): Allow users to provide feedback * feat: Allow users to provide feedback * Quick user switch in local-db mode * Add multiple attachments + download them * chore: Remove stale draft feedback SQL superseded by migration * fix: hide feedback icon when logged out (#36) * feat: Long press trick-card to change consistency (#37)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The feedback
IconButton(Icons.feedback_outlined) in the home screen app bar was rendered for all users, including logged-out ones. The/feedbackflow is only meaningful for authenticated users.Fix
Wrap the feedback
IconButtonin anif (AuthService.isLoggedIn)guard so it is only shown to logged-in users, matching the conditional pattern already used by the admin action directly below it.Only
lib/screens/home_screen.dartis changed.dart analyzereports no issues.