[Fix] 평가 Runner 및 NLG judge 검증 보강#161
Conversation
- 평가 CSV rejectionCodeCounts에서 NONE 제외 - 빈 questionAnalyses에 대한 judge 문장 평가 hallucination 검증 추가 - NLG judge OpenAI usage 기반 input/output token 기록 - EvaluationExitCoordinator 종료 실패 시 System.exit 보장 - 종료 Coordinator 중복 exit 요청 멱등성 테스트 추가 - 관련 평가 회귀 테스트 보강
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough평가 결과의 토큰 사용량 기록, 질문 평가 검증, 후보 결정 통계 집계가 수정되었습니다. 종료 연산은 주입 가능한 구현으로 분리되었으며, 중복 호출과 Spring 종료 예외를 검증하는 테스트가 추가되었습니다. Changes평가 분석 처리
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/test/java/com/jobdri/jobdri_api/domain/analysis/evaluation/EvaluationAnalysisRunnerSafetyTest.java`:
- Around line 360-377: Update the EvaluationExitCoordinator test to make the
Spring exit operation return a nonzero code such as 17, then assert that the
SystemExitOperation receives that returned code rather than the originally
requested code. Preserve the existing duplicate-exit assertions ensuring both
Spring and system exit operations execute only once.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 324b9ab8-9f7d-4811-9931-85c1d190fdfd
📒 Files selected for processing (7)
src/main/java/com/jobdri/jobdri_api/domain/analysis/evaluation/EvaluationAnalysisBatchService.javasrc/main/java/com/jobdri/jobdri_api/domain/analysis/evaluation/EvaluationExitCoordinator.javasrc/main/java/com/jobdri/jobdri_api/domain/analysis/evaluation/NlgEvaluationAiClient.javasrc/main/java/com/jobdri/jobdri_api/domain/analysis/evaluation/NlgEvaluationBatchService.javasrc/test/java/com/jobdri/jobdri_api/domain/analysis/evaluation/EvaluationAnalysisBatchServiceTest.javasrc/test/java/com/jobdri/jobdri_api/domain/analysis/evaluation/EvaluationAnalysisRunnerSafetyTest.javasrc/test/java/com/jobdri/jobdri_api/domain/analysis/evaluation/NlgEvaluationBatchServiceTest.java
- Spring exit 반환 코드와 요청 코드를 다르게 설정 - SystemExitOperation이 resolved exit code를 받는지 검증 - 중복 exit 요청 멱등성 검증 유지
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [ ]
Summary by CodeRabbit
NONE항목이 제외됩니다.