[Fix] NLG Judge 평가 기준을 서비스 정책에 맞게 정렬 - #224
Conversation
- MISSED_ANALYSIS 판정 기준을 명확한 문제 문장과 첨삭 가치 손실 중심으로 강화 - 명확한 문제 부재와 MISSED_ANALYSIS가 공존하지 않도록 Judge 프롬프트 보강 - MISSED_MISSING_KEYWORD 평가에서 자격증·면허·학력·경력 연차 등 정형 자격요건 제외 - JD에 없는 키워드와 OR 자격요건의 미선택지를 누락으로 보지 않도록 규칙 추가 - empty questionAnalyses 입력 시 평가 배열 생성 금지 계약 재강조 - overallUsefulness와 noAnalysisAppropriateness 1~5 rubric 구체화 - Judge 프롬프트 contract 테스트 추가
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/jobdri/jobdri_api/domain/analysis/evaluation/NlgEvaluationAiClient.java`:
- Around line 129-159: Refactor buildPrompt by extracting the MISSED_ANALYSIS
and MISSED_MISSING_KEYWORD rule text into separate private static final String
constants or focused helper methods, then compose those elements from
buildPrompt. Preserve the existing rule wording and prompt order while reducing
buildPrompt’s responsibility to assembling the prompt.
- Around line 94-97: Update the missingKeywords evaluation instructions in
NlgEvaluationAiClient so the rule that assigns MISSED_MISSING_KEYWORD when
actual=[] explicitly excludes structured qualification requirements such as
certifications, licenses, education, required experience years, and age. State
that the later exclusion policy takes precedence, preserving
MISSED_MISSING_KEYWORD only for non-structured missing JD/answer requirements.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cb881c4d-c585-482b-a984-710eee5da55e
⛔ Files ignored due to path filters (2)
evaluation/evaluation_nlg_judge_two_pass_provenance_strength_fix.csvis excluded by!**/*.csvevaluation/evaluation_nlg_judge_two_pass_provenance_strength_fix_comparison.csvis excluded by!**/*.csv
📒 Files selected for processing (2)
src/main/java/com/jobdri/jobdri_api/domain/analysis/evaluation/NlgEvaluationAiClient.javasrc/test/java/com/jobdri/jobdri_api/domain/analysis/evaluation/NlgEvaluationAiClientTest.java
- MISSED_ANALYSIS 판정 기준을 별도 상수로 분리 - MISSED_MISSING_KEYWORD 판정 기준을 별도 상수로 분리 - actual=[] missingKeywords 평가에서 정형 자격요건 제외 정책 우선순위 명시 - NLG Judge 프롬프트 contract 테스트 보강
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [#150 ]
Summary by CodeRabbit
변경 사항
개선
테스트