refactor: switch to codecs for nbt serialization by John-Paul-R · Pull Request #340 · John-Paul-R/Essential-Commands

John-Paul-R · 2025-06-24T03:10:40Z

No description provided.

not doing datafixer for homes/warps, since name can always come from map key

semanticdiff-com · 2025-06-24T03:10:42Z

Review changes with

Changed Files

File	Status
src/main/java/com/fibermc/essentialcommands/playerdata/PlayerDataFactory.java	56% smaller
src/main/java/com/fibermc/essentialcommands/types/NamedMinecraftLocation.java	24% smaller
src/main/java/com/fibermc/essentialcommands/types/WarpStorage.java	16% smaller
src/main/java/com/fibermc/essentialcommands/playerdata/PlayerData.java	16% smaller
src/main/java/com/fibermc/essentialcommands/types/NamedLocationStorage.java	15% smaller
src/main/java/com/fibermc/essentialcommands/WorldDataManager.java	15% smaller
src/main/java/com/fibermc/essentialcommands/util/EssentialsXParser.java	14% smaller
src/main/java/com/fibermc/essentialcommands/types/WarpLocation.java	12% smaller
ec-core/src/main/java/dev/jpcode/eccore/util/TextUtil.java	12% smaller
src/main/java/com/fibermc/essentialcommands/playerdata/PlayerDataManager.java	10% smaller
src/main/java/com/fibermc/essentialcommands/types/MinecraftLocation.java	4% smaller
src/main/java/com/fibermc/essentialcommands/WorldData.java	0% smaller
src/main/java/com/fibermc/essentialcommands/codec/Codecs.java	0% smaller
src/main/java/com/fibermc/essentialcommands/commands/HomeOverwriteCommand.java	0% smaller
src/main/java/com/fibermc/essentialcommands/commands/HomeSetCommand.java	0% smaller
src/main/java/com/fibermc/essentialcommands/mixin/WorldSaveHandlerMixin.java	0% smaller
src/main/java/com/fibermc/essentialcommands/util/EssentialsConvertor.java	0% smaller

src/main/java/com/fibermc/essentialcommands/types/NamedMinecraftLocation.java

src/main/java/com/fibermc/essentialcommands/types/WarpLocation.java

John-Paul-R · 2025-06-24T03:16:28Z

src/main/java/com/fibermc/essentialcommands/types/WarpStorage.java

+                var location = MinecraftLocation.fromNbt(homeTag);
+                super.put(
+                    name,


technically, the old and new Compound varieties should be format-compatible, as the new one is fairly forgiving. The NbtList one is can stick around for compatibility until if/when Mojang decides to break the methods used here in a complicated way.

John-Paul-R · 2025-06-24T03:16:59Z

src/main/java/com/fibermc/essentialcommands/types/NamedMinecraftLocation.java

        float headYaw,
        float pitch,
-        String name
+        Optional<String> name


this is ugly and probably deserves an inline comment with some capslock

src/main/java/com/fibermc/essentialcommands/playerdata/PlayerDataFactory.java

src/main/java/com/fibermc/essentialcommands/WorldData.java

src/main/java/com/fibermc/essentialcommands/codec/Codecs.java

John-Paul-R added 3 commits June 21, 2025 10:05

remove java version detection for placeholders parser

dfe446e

round one (need DFU for warped/named location)

3b41364

convert buncha other things to codecs, and actually track the codecs

36286de

not doing datafixer for homes/warps, since name can always come from map key