Zero initialize scaffold force vectors - #178
Merged
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the shared scaffold-force test failure that caused both PR 174 checks to fail. The GSL-backed Matrix(3, 1) constructor leaves storage uninitialized, while both the production per-scaffold accumulation buffer and the test expectation set or update only selected components. Use the existing zero-initializing Matrix(3, 1, true) form for both vectors so X/Y begin at zero and Z retains the expected physical force. Verification in WSL: focused regression pass; 20/20 repeated regression runs; standard full C++ suite 210/210; coverage-instrumented full C++ suite 210/210; git diff --check pass. LCOV capture was not run locally because lcov is absent from this WSL image; the GitHub workflow installs it before capture.