Add "View all notifications" page and link for notifications beyond the first 10#121
Merged
Sendi0011 merged 1 commit intoJun 26, 2026
Conversation
Adds a paginated full notification history page and a 'View all notifications' link in the dropdown, so users can see notifications beyond the most recent 10. Closes JointSave-org#110
Sendi0011
self-requested a review
June 26, 2026 17:26
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #110
useNotifications(and the/api/notificationsroute it calls) hardcoded a 10-row limit, so older notifications became permanently inaccessible from the UI once a user accumulated more than 10. This adds a way to view the full history.Changes
frontend/app/api/notifications/route.ts—GETnow supports an optional?page=<n>query param. When present, it returns paginated results ({ data, total, page, pageSize }) using the samecount: 'exact'+.range()pattern already used by/api/poolsfor My Groups. When absent, behavior is unchanged — still returns the most recent 10 for the dropdown.frontend/app/dashboard/notifications/page.tsx(new) — full notification history page for the connected wallet, using the same pagination UI/pattern as My Groups (Paginationcomponent,?page=URL param).frontend/components/dashboard/dashboard-header.tsx— adds a "View all notifications" link at the bottom of the dropdown, shown whenever there's at least one notification.Scope
Per the issue, this is scoped to just the page + link. Filtering/search on the notifications page is left as a follow-up.
Testing
.eq('wallet_address', wallet), and the page only ever requests the connected wallet's address..range()with a realcount: 'exact'total, not capped client-side.