fix(worker): reconcile ambiguous retry outcomes - #298
Merged
Joncallim merged 2 commits intoJul 28, 2026
Merged
Conversation
Joncallim
marked this pull request as ready for review
July 28, 2026 17:56
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 554b97de4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Joncallim
marked this pull request as draft
July 28, 2026 18:03
Joncallim
marked this pull request as ready for review
July 28, 2026 18:25
Joncallim
merged commit Jul 28, 2026
c74d427
into
codex/pr198-producer-5a2-r3a-retry-upgrade
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source Issue
Issue: #179
Parent
codex/pr198-producer-5a2-r3a-retry-upgrade279801f5cf47e130b652724f437775d5d749dffb11d999123947f6f5465d1a754ba421324e8ef75aSummary
When Redis may have applied retry-v3 but its response is lost, the worker replays the exact same retry transition once before closing the database attempt.
failedwith the retained business error and Redis’s authoritativenextRetryAt.indeterminate, retaining the business error with no claimed retry deadline.The dashboard presents
indeterminateas Retry status unknown with warning styling. Task-attempt logs use warning-levelqueue.attempt.indeterminateevidence and the existing safe compatibility message. The final-attempt dead-letter path and queue/Lua implementation remain unchanged. PostgreSQL already stores attempt status as unconstrained text, so this type/documentation refinement requires no migration.Local evidence
--noEmit: passedgit diff --check: passedfailedplus null deadline mutation: focused suite failed 2 tests as intendedHosted exact-head evidence
30386306983, job90366365188: passed30386325733, job90366494118: passedScope
Only:
web/worker/runtime.tsweb/worker/task-attempts.tsweb/db/schema.tsweb/app/dashboard/tasks/[id]/page.tsxweb/__tests__/core-diagnostic-output-closure.test.tsweb/__tests__/task-attempts.test.tsThis PR remains draft and stacked on #295. Its unresolved review thread is intentionally left unanswered and unresolved for the Reviewer gate.