Skip to content

Fix floor function - #172

Merged
mattt merged 1 commit into
Jounce:masterfrom
p-x9:fix-floor-function
Dec 30, 2020
Merged

Fix floor function#172
mattt merged 1 commit into
Jounce:masterfrom
p-x9:fix-floor-function

Conversation

@p-x9

@p-x9 p-x9 commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

'ceil' and 'floor' were calling the same function internally, and both were working as ceil.

2020-12-30 17 40 22

2020-12-30 17 40 44

@mattt mattt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @p-x9. Thanks for submitting this PR! It looks like your initial push got an unrelated CI failure, so I went ahead and fixed that with #173. Once we get ✅, I'll merge this in.

@mattt
mattt force-pushed the fix-floor-function branch from a45d847 to 8d992bf Compare December 30, 2020 12:57
@mattt
mattt merged commit 008ece8 into Jounce:master Dec 30, 2020
@p-x9
p-x9 deleted the fix-floor-function branch January 2, 2021 10:11
@mattt

mattt commented Jan 2, 2021

Copy link
Copy Markdown
Collaborator

@p-x9 Thanks again for your help with this. Your patch is now live in the latest release, 2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants