feat(staticanalysis): trivy mannifest scan command - #41
Merged
Conversation
vdayanand
previously approved these changes
Jun 5, 2026
vdayanand
left a comment
Member
There was a problem hiding this comment.
Reviewed the diff and verified the wire contract against the backend branch (nd/trivy-manifest-be): payload fields, default tool id, status state machine, CSV Accept negotiation, and run_uuid response shape all match. No behavior-breaking bugs found. Minor non-blocking polish items: results fetch has no retry (status polling does via apiGet), the upload log line claims Project.toml is included even when the file is empty (payload gates on content, message gates on path), and --poll-interval 0 would hot-loop.
vdayanand
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/JuliaComputing/JuliaHub/issues/21539