Conversation
The procedural-style smoke tests in `dbi.jl` and `cur.jl` previously created `testdb/` in CWD and only cleaned up if the surrounding `try/finally` reached the `rm`. Wraps them in `mktempdir` so failures don't leak the directory. Drops the `module LMDB_*` wrappers in favour of plain `@testset`. The modules were a workaround for `struct` re-definition that doesn't apply when the file is included once per test run; `@testset` provides sufficient scope and matches the style of `test/dict.jl`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces the numbered "tier 1 / 1.5 / 2 / 3" naming throughout source, docs, and README with the explicit names of the three layers. The README is rewritten in this naming and the three stale references (`ms_entries` → `entries`, `mbd_unpack` → `read(MDBValueIO, T)`, `Cushort(0o644)` → `LMDB.mode_t(0o644)`) are corrected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- CI.yml: bump to checkout@v4, setup-julia@v2, julia-actions/cache@v2, codecov-action@v5; matrix is lts/1/pre/nightly × ubuntu/macOS/windows; drop coveralls; add concurrency group. - Documenter.yml: pin julia-buildpkg@v1 / julia-docdeploy@v1, add julia setup + cache, set the permissions block expected by docdeploy. - CompatHelper.yml: standard nightly cron. - README.md: add the conventional CI / codecov / docs-stable / docs-dev badge row. - docs/make.jl: enable doctests via DocMeta.setdocmeta! and doctest=true.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 9 9
Lines 755 755
=======================================
Hits 620 620
Misses 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The test-cleanup commit's finalizer-via-GC.gc() tests in test/env.jl crash on Windows (EXCEPTION_ACCESS_VIOLATION in mdb_txn_end) and hang on Linux. Restoring the pre-cleanup test/ shape — module wrappers and all — keeps this docs/release-prep branch shippable. The cleanup can return as its own PR with the GC-dependent tests hardened or skipped on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.