Skip to content

Conversation

@mzgubic
Copy link
Member

@mzgubic mzgubic commented May 27, 2021

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #416 (c23c6ad) into master (dffe76c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          23       23           
  Lines        1929     1929           
=======================================
  Hits         1900     1900           
  Misses         29       29           
Impacted Files Coverage Δ
src/rulesets/Base/base.jl 100.00% <100.00%> (ø)
src/rulesets/Base/fastmath_able.jl 98.24% <100.00%> (ø)
src/rulesets/LinearAlgebra/symmetric.jl 99.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffe76c...c23c6ad. Read the comment docs.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a few of these be benchmarked to make sure it it doesn't introduce performance regressions?

Also it looks a bit funny to use true, should we add an explict note to @scalar_rule's docstring about this?

@mzgubic
Copy link
Member Author

mzgubic commented May 27, 2021

Can a few of these be benchmarked to make sure it it doesn't introduce performance regressions?

for reference JuliaDiff/ChainRulesCore.jl#357 (comment)

@mzgubic mzgubic merged commit 6f968ae into master May 27, 2021
@mzgubic mzgubic deleted the mz/one branch May 27, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants